Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9d2be928 authored by Dan Carpenter's avatar Dan Carpenter Committed by Konrad Rzeszutek Wilk
Browse files

xen/privcmd: return -EFAULT on error 



__copy_to_user() returns the number of bytes remaining to be copied but
we want to return a negative error code here.

Acked-by: default avatarAndres Lagar-Cavilla <andres@lagarcavilla.org>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
parent 1714df7f

drivers/xen/privcmd.c

+4 −1
Original line number Diff line number Diff line
@@ -389,8 +389,11 @@ static long privcmd_ioctl_mmap_batch(void __user *udata, int version) 
		state.err      = err_array;

		ret = traverse_pages(m.num, sizeof(xen_pfn_t),

				     &pagelist, mmap_return_errors_v1, &state);

	} else if (version == 2)

	} else if (version == 2) {

		ret = __copy_to_user(m.err, err_array, m.num * sizeof(int));

		if (ret)

			ret = -EFAULT;

	}



	/* If we have not had any EFAULT-like global errors then set the global

	 * error to -ENOENT if necessary. */