Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9ce0147f authored by Satya Rama Aditya Pinapala's avatar Satya Rama Aditya Pinapala Committed by Gerrit - the friendly Code Review server
Browse files

drm/msm/dsi-staging: avoid out of bounds access of ctrl array 



To avoid out of bounds access of ctrl array, an extra check
against maximum possible value is required. This is implemented in the
new macro display_for_each_ctrl.

Change-Id: I1511392f72df2faf9464d815810c8615925127fd
Signed-off-by: default avatarSatya Rama Aditya Pinapala <psraditya30@codeaurora.org>
parent eb7207c5

drivers/gpu/drm/msm/dsi-staging/dsi_defs.h

+3 −0
Original line number Diff line number Diff line
@@ -37,6 +37,9 @@ 
	})



#define DSI_DEBUG_NAME_LEN		32

#define display_for_each_ctrl(index, display) \

	for (index = 0; (index < (display)->ctrl_count) &&\

			(index < MAX_DSI_CTRLS_PER_DISPLAY); index++)

/**

 * enum dsi_pixel_format - DSI pixel formats

 * @DSI_PIXEL_FORMAT_RGB565:

drivers/gpu/drm/msm/dsi-staging/dsi_display.c

+71 −77

File changed.

Preview size limit exceeded, changes collapsed.

drivers/gpu/drm/msm/dsi-staging/dsi_drm.c

+1 −1
Original line number Diff line number Diff line
@@ -749,7 +749,7 @@ int dsi_conn_post_kickoff(struct drm_connector *connector) 
		}



		/* Update the rest of the controllers */

		for (i = 0; i < display->ctrl_count; i++) {

		display_for_each_ctrl(i, display) {

			ctrl = &display->ctrl[i];

			if (!ctrl->ctrl || (ctrl == m_ctrl))

				continue;