Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9be00d67 authored by Matt Jared's avatar Matt Jared Committed by Jeff Kirsher
Browse files

i40e: fix led blink toggle to enable steady state 



Make sure to clear the GPIO blink field, instead of OR'ing against zero
if the field is already '1'.

Change-ID: Ie52a52abd48f6f52b20778a6b8b0c542dfc9245c
Signed-off-by: default avatarMatt Jared <matthew.a.jared@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent c29af37f

drivers/net/ethernet/intel/i40e/i40e_common.c

+4 −2
Original line number Diff line number Diff line
@@ -1142,8 +1142,10 @@ void i40e_led_set(struct i40e_hw *hw, u32 mode, bool blink) 
		if (mode == I40E_LINK_ACTIVITY)

			blink = false;



		gpio_val |= (blink ? 1 : 0) <<

			    I40E_GLGEN_GPIO_CTL_LED_BLINK_SHIFT;

		if (blink)

			gpio_val |= (1 << I40E_GLGEN_GPIO_CTL_LED_BLINK_SHIFT);

		else

			gpio_val &= ~(1 << I40E_GLGEN_GPIO_CTL_LED_BLINK_SHIFT);



		wr32(hw, I40E_GLGEN_GPIO_CTL(i), gpio_val);

		break;