Commit 9b335978 authored Jul 25, 2016 by Dave Jiang Committed by Vinod Koul Aug 08, 2016

dmaengine: fsldma: move unmap to before callback



Completion callback should happen after dma_descriptor_unmap() has
happened. This allow the cache invalidate to happen and ensure that
the data accessed by the upper layer is in memory that was from DMA
rather than stale data. On some architecture this is done by the
hardware, however we should make the code consistent to not cause
confusion.

Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Acked-by: Li Yang <leoyang.li@nxp.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

parent 73fc45e3

drivers/dma/fsldma.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -516,9 +516,9 @@ static dma_cookie_t fsldma_run_tx_complete_actions(struct fsldma_chan *chan,
		if (txd->cookie > 0) {
		ret = txd->cookie;

		dma_descriptor_unmap(txd);
		/* Run the link descriptor callback function */
		dmaengine_desc_get_callback_invoke(txd, NULL);
		dma_descriptor_unmap(txd);
		}

		/* Run any dependencies */