Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9b263363 authored by Daniel Wagner's avatar Daniel Wagner Committed by Mauro Carvalho Chehab
Browse files

[media] lirc_imon: use complete() instead complete_all() 



There is only one waiter for the completion, therefore there
is no need to use complete_all(). Let's make that clear by
using complete() instead of complete_all().

While we are at it, we do a small optimization with the
reinitialization of the completion before we use it.

The usage pattern of the completion is:

waiter context                          waker context

send_packet()
  reinit_completion()
  usb_sumbit_urb()
  wait_for_completion_interruptible()

                                        usb_tx_callback()
                                          complete()

                                        imon_disconnect()
                                          complete()

Signed-off-by: default avatarDaniel Wagner <daniel.wagner@bmw-carit.de>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 7c073fff

drivers/staging/media/lirc/lirc_imon.c

+4 −2
Original line number Diff line number Diff line
@@ -334,7 +334,7 @@ static int send_packet(struct imon_context *context) 


	context->tx_urb->actual_length = 0;



	init_completion(&context->tx.finished);

	reinit_completion(&context->tx.finished);

	atomic_set(&context->tx.busy, 1);



	retval = usb_submit_urb(context->tx_urb, GFP_KERNEL);
@@ -497,6 +497,8 @@ static int ir_open(void *data) 
	context->rx.initial_space = 1;

	context->rx.prev_bit = 0;



	init_completion(&context->tx.finished);



	context->ir_isopen = 1;

	dev_info(context->driver->dev, "IR port opened\n");
@@ -930,7 +932,7 @@ static void imon_disconnect(struct usb_interface *interface) 
	/* Abort ongoing write */

	if (atomic_read(&context->tx.busy)) {

		usb_kill_urb(context->tx_urb);

		complete_all(&context->tx.finished);

		complete(&context->tx.finished);

	}



	context->dev_present = 0;