Commit 99976fc0 authored Aug 03, 2017 by Wright Feng Committed by Kalle Valo Aug 08, 2017

brcmfmac: fix wrong num_different_channels when mchan feature enabled

When the device/firmware supports multi-channel, it can have P2P
connection and regular connection with AP simultaneous. In this case,
the num_different_channels in wiphy info was not correct when firmware
supports multi-channel (The iw wiphy# info showed "#channels <= 1" in
interface combinations). It caused association failed and error message
"CTRL-EVENT-FREQ-CONFLICT error" in wpa_supplicant when P2P GO interface
was running at the same time.
The root cause is that the num_different_channels was always overridden
to 1 in brcmf_setup_ifmodes even multi-channel was enabled.
We correct the logic by moving num_different_channels setting forward.

Signed-off-by: Wright Feng <wright.feng@cypress.com>
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent 0ec9eb90

drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -6461,6 +6461,8 @@ static int brcmf_setup_ifmodes(struct wiphy wiphy, struct brcmf_if ifp)
		if (p2p) {
		if (brcmf_feat_is_enabled(ifp, BRCMF_FEAT_MCHAN))
		combo[c].num_different_channels = 2;
		else
		combo[c].num_different_channels = 1;
		wiphy->interface_modes \|= BIT(NL80211_IFTYPE_P2P_CLIENT) \|
		BIT(NL80211_IFTYPE_P2P_GO) \|
		BIT(NL80211_IFTYPE_P2P_DEVICE);
		@@ -6470,10 +6472,10 @@ static int brcmf_setup_ifmodes(struct wiphy wiphy, struct brcmf_if ifp)
		c0_limits[i++].types = BIT(NL80211_IFTYPE_P2P_CLIENT) \|
		BIT(NL80211_IFTYPE_P2P_GO);
		} else {
		combo[c].num_different_channels = 1;
		c0_limits[i].max = 1;
		c0_limits[i++].types = BIT(NL80211_IFTYPE_AP);
		}
		combo[c].num_different_channels = 1;
		combo[c].max_interfaces = i;
		combo[c].n_limits = i;
		combo[c].limits = c0_limits;