Commit 988e7520 authored May 26, 2011 by Márton Németh Committed by Greg Kroah-Hartman Jun 07, 2011

usbip: remove check for negative values for an unsigned value

The parameter rhport is unsigned so there is no need checking for
negative values.

This will remove the following warning message when compiling with "make W=1 ...":
drivers/staging/usbip/vhci_sysfs.c: In function ‘valid_args’:
drivers/staging/usbip/vhci_sysfs.c:138: warning: comparison of unsigned expression < 0 is always false

Signed-off-by: Márton Németh <nm127@freemail.hu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 9ba422b3

drivers/staging/usbip/vhci_sysfs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -135,7 +135,7 @@ static DEVICE_ATTR(detach, S_IWUSR, NULL, store_detach);
		static int valid_args(__u32 rhport, enum usb_device_speed speed)
		{
		/* check rhport */
		if ((rhport < 0) \|\| (rhport >= VHCI_NPORTS)) {
		if (rhport >= VHCI_NPORTS) {
		pr_err("port %u\n", rhport);
		return -EINVAL;
		}