Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 97e1efbb authored by Antonio Ospite's avatar Antonio Ospite Committed by Jiri Kosina
Browse files

HID: bt hidp: send Output reports using SET_REPORT on the Control channel 

The current implementation of hidp_output_raw_report() relies only on
the Control channel even for Output reports, and the BT HID
specification [1] does not mention using the DATA message for Output
reports on the Control channel (see section 7.9.1 and also Figure 11:
SET_ Flow Chart), so let us just use SET_REPORT.

This also fixes sending Output reports to some devices (like Sony
Sixaxis) which are not able to handle DATA messages on the Control
channel.

Ideally hidp_output_raw_report() could be improved to use this scheme:
  Feature Report -- SET_REPORT on the Control channel
  Output Report  -- DATA on the Interrupt channel
for more efficiency, but as said above, right now only the Control
channel is used.

[1] http://www.bluetooth.com/Specification%20Documents/HID_SPEC_V10.pdf



Signed-off-by: default avatarAntonio Ospite <ospite@studenti.unina.it>
Acked-by: default avatarGustavo F. Padovan <padovan@profusion.mobi>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 5710fabf

net/bluetooth/hidp/core.c

+1 −1
Original line number Diff line number Diff line
@@ -321,7 +321,7 @@ static int hidp_output_raw_report(struct hid_device *hid, unsigned char *data, s 
		report_type = HIDP_TRANS_SET_REPORT | HIDP_DATA_RTYPE_FEATURE;

		break;

	case HID_OUTPUT_REPORT:

		report_type = HIDP_TRANS_DATA | HIDP_DATA_RTYPE_OUPUT;

		report_type = HIDP_TRANS_SET_REPORT | HIDP_DATA_RTYPE_OUPUT;

		break;

	default:

		return -EINVAL;