Commit 972cfd55 authored Oct 25, 2015 by Julia Lawall Committed by Ralf Baechle Nov 11, 2015

MIPS: pci-rt3883: drop unneeded of_node_get

for_each_child_of_node performs an of_node_get on each iteration, so no
of_node_get is needed on breaking out of the loop when the device_node
structure is saved in another variable.

A simplified semantic match that finds this problem is as follows
(http://coccinelle.lip6.fr

):

// <smpl>
@@
expression root;
local idexpression child;
@@

 for_each_child_of_node(root, child) {
   ...
*  of_node_get(child)
   ...
   break;
 }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Patchwork: https://patchwork.linux-mips.org/patch/11357/


Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

parent a7f4df4e

arch/mips/pci/pci-rt3883.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -432,8 +432,7 @@ static int rt3883_pci_probe(struct platform_device *pdev)

		/* find the interrupt controller child node */
		for_each_child_of_node(np, child) {
		if (of_get_property(child, "interrupt-controller", NULL) &&
		of_node_get(child)) {
		if (of_get_property(child, "interrupt-controller", NULL)) {
		rpc->intc_of_node = child;
		break;
		}
		@@ -449,8 +448,7 @@ static int rt3883_pci_probe(struct platform_device *pdev)
		/* find the PCI host bridge child node */
		for_each_child_of_node(np, child) {
		if (child->type &&
		of_node_cmp(child->type, "pci") == 0 &&
		of_node_get(child)) {
		of_node_cmp(child->type, "pci") == 0) {
		rpc->pci_controller.of_node = child;
		break;
		}