Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 96b45ea5 authored by Jean Delvare's avatar Jean Delvare Committed by Bjorn Helgaas
Browse files

PCI/AER: Log actual error causes in aer_inject 



The aer_inject driver is very quiet.  In most cases, it merely returns an
error code to user-space, leaving the user with little clue about the
actual reason for the failure.

So, log error messages for 4 of the most frequent causes of failure:
* Can't find the root port of the specified device.
* Device doesn't support AER.
* Root port doesn't support AER.
* AER device not found.

This gives the user a chance to understand why aer-inject failed.

Based on a preliminary patch by Thomas Renninger.

Signed-off-by: default avatarJean Delvare <jdelvare@suse.de>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
CC: Borislav Petkov <bp@suse.de>
CC: Thomas Renninger <trenn@suse.de>
parent 3bc11851

drivers/pci/pcie/aer/aer_inject.c

+7 −1
Original line number Diff line number Diff line
@@ -358,12 +358,14 @@ static int aer_inject(struct aer_error_inj *einj) 
		return -ENODEV;

	rpdev = pcie_find_root_port(dev);

	if (!rpdev) {

		dev_err(&dev->dev, "aer_inject: Root port not found\n");

		ret = -ENODEV;

		goto out_put;

	}



	pos_cap_err = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ERR);

	if (!pos_cap_err) {

		dev_err(&dev->dev, "aer_inject: Device doesn't support AER\n");

		ret = -EPROTONOSUPPORT;

		goto out_put;

	}
@@ -374,6 +376,8 @@ static int aer_inject(struct aer_error_inj *einj) 


	rp_pos_cap_err = pci_find_ext_capability(rpdev, PCI_EXT_CAP_ID_ERR);

	if (!rp_pos_cap_err) {

		dev_err(&rpdev->dev,

			"aer_inject: Root port doesn't support AER\n");

		ret = -EPROTONOSUPPORT;

		goto out_put;

	}
@@ -489,8 +493,10 @@ static int aer_inject(struct aer_error_inj *einj) 
			goto out_put;

		}

		aer_irq(-1, edev);

	} else

	} else {

		dev_err(&rpdev->dev, "aer_inject: AER device not found\n");

		ret = -ENODEV;

	}

out_put:

	kfree(err_alloc);

	kfree(rperr_alloc);