Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 962f3ffa authored by Akinobu Mita's avatar Akinobu Mita Committed by Greg Kroah-Hartman
Browse files

wusb: fix find_first_zero_bit() return value check 



In wusb_cluster_id_get(), if no zero bits exist in wusb_cluster_id_table,
find_first_zero_bit() returns CLUSTER_IDS.

But it is impossible to detect that the bitmap is full because there
is an off-by-one error in the return value check.  It will cause
unexpected memory access by setting bit out of wusb_cluster_id_table
bitmap, and caller will get wrong cluster id.

Signed-off-by: default avatarAkinobu Mita <akinobu.mita@gmail.com>
Cc: linux-usb@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 60b0bf0f

drivers/usb/wusbcore/wusbhc.c

+1 −1
Original line number Diff line number Diff line
@@ -320,7 +320,7 @@ u8 wusb_cluster_id_get(void) 
	u8 id;

	spin_lock(&wusb_cluster_ids_lock);

	id = find_first_zero_bit(wusb_cluster_id_table, CLUSTER_IDS);

	if (id > CLUSTER_IDS) {

	if (id >= CLUSTER_IDS) {

		id = 0;

		goto out;

	}