Commit 95de86cf authored Sep 28, 2011 by Brian King Committed by David S. Miller Sep 29, 2011

ibmveth: Fix oops on request_irq failure



If request_irq fails, the ibmveth driver will overwrite
the rc and end up returning a successful rc on its open
function, resulting in an oops later when a packet gets
sent and buffers are not allocated due to the failed open.

Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 676a1184

drivers/net/ibmveth.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -636,8 +636,8 @@ static int ibmveth_open(struct net_device *netdev)
		netdev_err(netdev, "unable to request irq 0x%x, rc %d\n",
		netdev->irq, rc);
		do {
		rc = h_free_logical_lan(adapter->vdev->unit_address);
		} while (H_IS_LONG_BUSY(rc) \|\| (rc == H_BUSY));
		lpar_rc = h_free_logical_lan(adapter->vdev->unit_address);
		} while (H_IS_LONG_BUSY(lpar_rc) \|\| (lpar_rc == H_BUSY));

		goto err_out;
		}