Commit 95c0bae7 authored May 02, 2019 by Mayank Rana

usb: gadget: f_serial: Use snprintf() instead of sprintf()

USB serial function driver uses sprintf() to expose port number value to
userspace. sprintf() may result into buffer overrun. Hence use snprintf()
instead of sprintf() which also fixes static analysis tool reported error.

Change-Id: I66532dd9a7bdeb572f0289e393128df4ea4e5f38
Signed-off-by: Mayank Rana <mrana@codeaurora.org>

parent 11276b2c

drivers/usb/gadget/function/f_serial.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -712,7 +712,8 @@ static struct configfs_item_operations serial_item_ops = {

		static ssize_t f_serial_port_num_show(struct config_item item, char page)
		{
		return sprintf(page, "%u\n", to_f_serial_opts(item)->port_num);
		return snprintf(page, PAGE_SIZE, "%u\n",
		to_f_serial_opts(item)->port_num);
		}

		CONFIGFS_ATTR_RO(f_serial_, port_num);