Commit 93e4f47f authored Mar 15, 2013 by Ming Lei Committed by Greg Kroah-Hartman Mar 25, 2013

USB: serial: comments on suspend failure



If suspend callback fails in system sleep context, usb core will
ignore the failure and let system sleep go ahead further, so
this patch comments on the case and requires that serial->type->suspend()
MUST return 0 in system sleep context.

Acked-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 303f0847

drivers/usb/serial/usb-serial.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -1137,6 +1137,11 @@ int usb_serial_suspend(struct usb_interface *intf, pm_message_t message)

		serial->suspending = 1;

		/*
		* serial->type->suspend() MUST return 0 in system sleep context,
		* otherwise, the resume callback has to recover device from
		* previous suspend failure.
		*/
		if (serial->type->suspend) {
		r = serial->type->suspend(serial, message);
		if (r < 0) {