Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 93bc73b8 authored by Jesse Brandeburg's avatar Jesse Brandeburg Committed by Jeff Kirsher
Browse files

i40e: use common failure flow 



As mentioned by Joe Perches, we should be using
foo = alloc(...)
if (!foo)
	return -ENOMEM;

return 0;

Signed-off-by: default avatarJesse Brandeburg <jesse.brandeburg@intel.com>
CC: Joe Perches <joe@perches.com>
Tested-by: default avatarKavindya Deegala <kavindya.s.deegala@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 5aa3a449

drivers/net/ethernet/intel/i40e/i40e_main.c

+6 −6
Original line number Diff line number Diff line
@@ -101,10 +101,10 @@ int i40e_allocate_dma_mem_d(struct i40e_hw *hw, struct i40e_dma_mem *mem, 
	mem->size = ALIGN(size, alignment);

	mem->va = dma_zalloc_coherent(&pf->pdev->dev, mem->size,

				      &mem->pa, GFP_KERNEL);

	if (mem->va)

		return 0;



	if (!mem->va)

		return -ENOMEM;



	return 0;

}



/**
@@ -136,10 +136,10 @@ int i40e_allocate_virt_mem_d(struct i40e_hw *hw, struct i40e_virt_mem *mem, 
	mem->size = size;

	mem->va = kzalloc(size, GFP_KERNEL);



	if (mem->va)

		return 0;



	if (!mem->va)

		return -ENOMEM;



	return 0;

}



/**