Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 92e93a1f authored by HeungJun Kim's avatar HeungJun Kim Committed by Mauro Carvalho Chehab
Browse files

[media] m5mols: Optimize the capture set up sequence 



Improve the single frame capture set up sequence. Since there is
no need to re-enable the interrupts in each capture sequence, unmask
the required interrupts once at the device initialization time.

Signed-off-by: default avatarHeungJun Kim <riverful.kim@samsung.com>
Signed-off-by: default avatarSylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: default avatarKyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 0f2ee1dd

drivers/media/video/m5mols/m5mols_capture.c

+10 −24
Original line number Diff line number Diff line
@@ -108,47 +108,33 @@ int m5mols_start_capture(struct m5mols_info *info) 
	int ret;



	/*

	 * Preparing capture. Setting control & interrupt before entering

	 * capture mode

	 *

	 * 1) change to MONITOR mode for operating control & interrupt

	 * 2) set controls (considering v4l2_control value & lock 3A)

	 * 3) set interrupt

	 * 4) change to CAPTURE mode

	 * Synchronize the controls, set the capture frame resolution and color

	 * format. The frame capture is initiated during switching from Monitor

	 * to Capture mode.

	 */

	ret = m5mols_mode(info, REG_MONITOR);

	if (!ret)

		ret = m5mols_sync_controls(info);

	if (!ret)

		ret = m5mols_lock_3a(info, true);

		ret = m5mols_write(sd, CAPP_YUVOUT_MAIN, REG_JPEG);

	if (!ret)

		ret = m5mols_enable_interrupt(sd, REG_INT_CAPTURE);

		ret = m5mols_write(sd, CAPP_MAIN_IMAGE_SIZE, resolution);

	if (!ret)

		ret = m5mols_lock_3a(info, true);

	if (!ret)

		ret = m5mols_mode(info, REG_CAPTURE);

	if (!ret)

		/* Wait for capture interrupt, after changing capture mode */

		/* Wait until a frame is captured to ISP internal memory */

		ret = m5mols_wait_interrupt(sd, REG_INT_CAPTURE, 2000);

	if (!ret)

		ret = m5mols_lock_3a(info, false);

	if (ret)

		return ret;



	/*

	 * Starting capture. Setting capture frame count and resolution and

	 * the format(available format: JPEG, Bayer RAW, YUV).

	 *

	 * 1) select single or multi(enable to 25), format, size

	 * 2) set interrupt

	 * 3) start capture(for main image, now)

	 * 4) get information

	 * 5) notify file size to v4l2 device(e.g, to s5p-fimc v4l2 device)

	 * Initiate the captured data transfer to a MIPI-CSI receiver.

	 */

	ret = m5mols_write(sd, CAPC_SEL_FRAME, 1);

	if (!ret)

		ret = m5mols_write(sd, CAPP_YUVOUT_MAIN, REG_JPEG);

	if (!ret)

		ret = m5mols_write(sd, CAPP_MAIN_IMAGE_SIZE, resolution);

	if (!ret)

		ret = m5mols_enable_interrupt(sd, REG_INT_CAPTURE);

	if (!ret)

		ret = m5mols_write(sd, CAPC_START, REG_CAP_START_MAIN);

	if (!ret) {

drivers/media/video/m5mols/m5mols_core.c

+2 −1
Original line number Diff line number Diff line
@@ -788,7 +788,8 @@ static int m5mols_fw_start(struct v4l2_subdev *sd) 


	ret = m5mols_write(sd, PARM_INTERFACE, REG_INTERFACE_MIPI);

	if (!ret)

		ret = m5mols_enable_interrupt(sd, REG_INT_AF);

		ret = m5mols_enable_interrupt(sd,

				REG_INT_AF | REG_INT_CAPTURE);



	return ret;

}