Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 918b4056 authored by Julia Lawall's avatar Julia Lawall Committed by Guenter Roeck
Browse files

hwmon: (mc13783-adc) use permission-specific DEVICE_ATTR variants 



Use DEVICE_ATTR_RO for read-only attributes. This simplifies the source
code, improves readbility, and reduces the chance of inconsistencies.

The conversion was done automatically using coccinelle. It was validated
by compiling both the old and the new source code and comparing its text,
data, and bss size.

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
[groeck: Updated description]
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent a93c843b

drivers/hwmon/mc13783-adc.c

+3 −3
Original line number Diff line number Diff line
@@ -40,8 +40,8 @@ struct mc13783_adc_priv { 
	char name[PLATFORM_NAME_SIZE];

};



static ssize_t mc13783_adc_show_name(struct device *dev, struct device_attribute

			      *devattr, char *buf)

static ssize_t name_show(struct device *dev, struct device_attribute *devattr,

			 char *buf)

{

	struct mc13783_adc_priv *priv = dev_get_drvdata(dev);
@@ -111,7 +111,7 @@ static ssize_t mc13783_adc_read_gp(struct device *dev, 
	return sprintf(buf, "%u\n", val);

}



static DEVICE_ATTR(name, S_IRUGO, mc13783_adc_show_name, NULL);

static DEVICE_ATTR_RO(name);

static SENSOR_DEVICE_ATTR(in2_input, S_IRUGO, mc13783_adc_read_bp, NULL, 2);

static SENSOR_DEVICE_ATTR(in5_input, S_IRUGO, mc13783_adc_read_gp, NULL, 5);

static SENSOR_DEVICE_ATTR(in6_input, S_IRUGO, mc13783_adc_read_gp, NULL, 6);