Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 902943c0 authored by Niklas Cassel's avatar Niklas Cassel Committed by David S. Miller
Browse files

dwc_eth_qos: do not clear pause flags from phy_device->supported 



phy_device->supported is originally set by the PHY driver.
The ethernet driver should filter phy_device->supported to only contain
flags supported by the IP.
The IP supports setting rx and tx flow control independently,
therefore SUPPORTED_Pause and SUPPORTED_Asym_Pause should not be cleared.
If the flags are cleared, pause frames cannot be enabled (even if they
are supported by the PHY).

Signed-off-by: default avatarNiklas Cassel <niklas.cassel@axis.com>
Signed-off-by: default avatarJesper Nilsson <jespern@axis.com>
Acked-by: default avatarLars Persson <larper@axis.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8d324fd9

drivers/net/ethernet/synopsys/dwc_eth_qos.c

+2 −1
Original line number Diff line number Diff line
@@ -982,7 +982,8 @@ static int dwceqos_mii_probe(struct net_device *ndev) 
	if (netif_msg_probe(lp))

		phy_attached_info(phydev);



	phydev->supported &= PHY_GBIT_FEATURES;

	phydev->supported &= PHY_GBIT_FEATURES | SUPPORTED_Pause |

			     SUPPORTED_Asym_Pause;



	lp->link    = 0;

	lp->speed   = 0;