Commit 8fa4011e authored May 23, 2017 by Bart Van Assche Committed by Nicholas Bellinger Jul 06, 2017

target/iscsi: Remove dead code from iscsit_process_scsi_cmd()



If an iSCSI command is rejected before iscsit_process_scsi_cmd()
is called, .reject_reason is set but iscsit_process_scsi_cmd() is
not called. This means that the "if (cmd->reject_reason) ..." code
in this function can be removed without changing the behavior of
this function.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Hannes Reinecke <hare@suse.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Andy Grover <agrover@redhat.com>
Cc: David Disseldorp <ddiss@suse.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

parent d1c26857

drivers/target/iscsi/iscsi_target.c

+1 −5

Original line number	Diff line number	Diff line
		@@ -1249,12 +1249,8 @@ int iscsit_process_scsi_cmd(struct iscsi_conn conn, struct iscsi_cmd cmd,
		* execution. These exceptions are processed in CmdSN order using
		* iscsit_check_received_cmdsn() in iscsit_get_immediate_data() below.
		*/
		if (cmd->sense_reason) {
		if (cmd->reject_reason)
		return 0;

		if (cmd->sense_reason)
		return 1;
		}
		/*
		* Call directly into transport_generic_new_cmd() to perform
		* the backend memory allocation.