Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8f493d79 authored by Andi Kleen's avatar Andi Kleen Committed by Linus Torvalds
Browse files

[PATCH] Make sure interleave masks have at least one node set 



Otherwise a bad mem policy system call can confuse the interleaving
code into referencing undefined nodes.

Originally reported by Doug Chapman

I was told it's CVE-2005-3358
(one has to love these security people - they make everything sound important)

Signed-off-by: default avatarAndi Kleen <ak@suse.de>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent abe842eb

mm/mempolicy.c

+4 −0
Original line number Diff line number Diff line
@@ -161,6 +161,10 @@ static struct mempolicy *mpol_new(int mode, nodemask_t *nodes) 
	switch (mode) {

	case MPOL_INTERLEAVE:

		policy->v.nodes = *nodes;

		if (nodes_weight(*nodes) == 0) {

			kmem_cache_free(policy_cache, policy);

			return ERR_PTR(-EINVAL);

		}

		break;

	case MPOL_PREFERRED:

		policy->v.preferred_node = first_node(*nodes);