Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8e6fe35e authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Mark Brown
Browse files

ASoC: lm49453: Remove unnecessary suspend/resume bias level changes 



The ASoC core will only call the suspend/resume callbacks when the device's
DAPM context is idle. Since this driver sets idle_bias_off to true this
means that the device is already in SND_SOC_BIAS_OFF when the suspend
callback is called, so there is no need to manually set this state again.
There is also no need to go to SND_SOC_BIAS_STANDBY in the resume callback
since the core will go right back to SND_SOC_BIAS_OFF.

Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent b43cfb24

sound/soc/codecs/lm49453.c

+0 −14
Original line number Original line Diff line number Diff line
@@ -1395,18 +1395,6 @@ static struct snd_soc_dai_driver lm49453_dai[] = { 
	},

	},

};

};





static int lm49453_suspend(struct snd_soc_codec *codec)

{

	lm49453_set_bias_level(codec, SND_SOC_BIAS_OFF);

	return 0;

}



static int lm49453_resume(struct snd_soc_codec *codec)

{

	lm49453_set_bias_level(codec, SND_SOC_BIAS_STANDBY);

	return 0;

}



/* power down chip */

/* power down chip */

static int lm49453_remove(struct snd_soc_codec *codec)

static int lm49453_remove(struct snd_soc_codec *codec)

{

{
@@ -1416,8 +1404,6 @@ static int lm49453_remove(struct snd_soc_codec *codec) 




static struct snd_soc_codec_driver soc_codec_dev_lm49453 = {

static struct snd_soc_codec_driver soc_codec_dev_lm49453 = {

	.remove = lm49453_remove,

	.remove = lm49453_remove,

	.suspend = lm49453_suspend,

	.resume = lm49453_resume,

	.set_bias_level = lm49453_set_bias_level,

	.set_bias_level = lm49453_set_bias_level,

	.controls = lm49453_snd_controls,

	.controls = lm49453_snd_controls,

	.num_controls = ARRAY_SIZE(lm49453_snd_controls),

	.num_controls = ARRAY_SIZE(lm49453_snd_controls),