Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d9233f2 authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

perf kmem: Use memdup() 

Instead of hand coded equivalent.

Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-42ldngi973f4ssvzlklo8t2k@git.kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 8e16017d

tools/perf/builtin-kmem.c

+3 −3
Original line number Diff line number Diff line
@@ -17,6 +17,7 @@ 
#include "util/debug.h"



#include <linux/rbtree.h>

#include <linux/string.h>



struct alloc_stat;

typedef int (*sort_fn_t)(struct alloc_stat *, struct alloc_stat *);
@@ -618,12 +619,11 @@ static int sort_dimension__add(const char *tok, struct list_head *list) 


	for (i = 0; i < NUM_AVAIL_SORTS; i++) {

		if (!strcmp(avail_sorts[i]->name, tok)) {

			sort = malloc(sizeof(*sort));

			sort = memdup(avail_sorts[i], sizeof(*avail_sorts[i]));

			if (!sort) {

				pr_err("%s: malloc failed\n", __func__);

				pr_err("%s: memdup failed\n", __func__);

				return -1;

			}

			memcpy(sort, avail_sorts[i], sizeof(*sort));

			list_add_tail(&sort->list, list);

			return 0;

		}