Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 89b59e6c authored by Huang Shijie's avatar Huang Shijie Committed by Brian Norris
Browse files

mtd: gpmi: add a new DT property to use the datasheet's minimum required ECC 



In default way, we use the ecc_strength/ecc_step size calculated by ourselves
and use all the OOB area.

This patch adds a new property : "fsl,use-minimum-ecc"

If we enable it, we will firstly try to use the datasheet's minimum required
ECC provided by the MTD layer (the ecc_strength_ds/ecc_step_ds fields
in the nand_chip{}). So we may have free space in the OOB area by using the
minimum ECC, and we may support JFFS2 with some SLC NANDs, such as Micron's
SLC NAND.

If we fail to use the minimum ECC, we will use the legacy method to calculate
the ecc_strength and ecc_step size.

Signed-off-by: default avatarHuang Shijie <b32955@freescale.com>
Signed-off-by: default avatarBrian Norris <computersforpeace@gmail.com>
parent 43b77693

Documentation/devicetree/bindings/mtd/gpmi-nand.txt

+8 −0
Original line number Diff line number Diff line
@@ -17,6 +17,14 @@ Required properties: 
Optional properties:

  - nand-on-flash-bbt: boolean to enable on flash bbt option if not

                       present false

  - fsl,use-minimum-ecc: Protect this NAND flash with the minimum ECC

                       strength required. The required ECC strength is

                       automatically discoverable for some flash

                       (e.g., according to the ONFI standard).

                       However, note that if this strength is not

                       discoverable or this property is not enabled,

                       the software may chooses an implementation-defined

                       ECC scheme.



The device tree may optionally contain sub-nodes describing partitions of the

address space. See partition.txt for more detail.

drivers/mtd/nand/gpmi-nand/gpmi-nand.c

+3 −0
Original line number Diff line number Diff line
@@ -352,6 +352,9 @@ static int legacy_set_geometry(struct gpmi_nand_data *this) 


int common_nfc_set_geometry(struct gpmi_nand_data *this)

{

	if (of_property_read_bool(this->dev->of_node, "fsl,use-minimum-ecc")

		&& set_geometry_by_ecc_info(this))

		return 0;

	return legacy_set_geometry(this);

}