Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 898805e0 authored by Russell King's avatar Russell King Committed by David S. Miller
Browse files

net: phy: fix marvell phy status reading 



The Marvell driver incorrectly provides phydev->lp_advertising as the
logical and of the link partner's advert and our advert.  This is
incorrect - this field is supposed to store the link parter's unmodified
advertisment.

This allows ethtool to report the correct link partner auto-negotiation
status.

Fixes: be937f1f ("Marvell PHY m88e1111 driver fix")
Signed-off-by: default avatarRussell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 15e56515

drivers/net/phy/marvell.c

+0 −2
Original line number Diff line number Diff line
@@ -1127,8 +1127,6 @@ static int marvell_read_status_page(struct phy_device *phydev, int page) 
		if (adv < 0)

			return adv;



		lpa &= adv;



		if (status & MII_M1011_PHY_STATUS_FULLDUPLEX)

			phydev->duplex = DUPLEX_FULL;

		else