Commit 895875a3 authored May 29, 2015 by Nicholas Mc Guire Committed by Greg Kroah-Hartman May 31, 2015

staging: panel: use schedule_timeout_interruptible()



API consolidation with coccinelle found:
./drivers/staging/panel/panel.c:782:2-18:
        consolidation with schedule_timeout_*() recommended

This is a 1:1 conversion with respect to schedule_timeout() to the
schedule_timeout_interruptible() helper only - so only an API
consolidation to improve readability. The timeout was being passed
as (ms * HZ + 999) / 1000 but that simply looks wrong - rather than
"manual" converting to jiffies, msecs_to_jiffies which handles all
corner-cases correctly, was used.

Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y,
CONFIG_PARPORT=m, CONFIG_PANEL=m

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Acked-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 60c77d1a

drivers/staging/panel/panel.c

+3 −5

Original line number	Diff line number	Diff line
		@@ -775,12 +775,10 @@ static void pin_to_bits(int pin, unsigned char d_val, unsigned char c_val)
		/* sleeps that many milliseconds with a reschedule */
		static void long_sleep(int ms)
		{
		if (in_interrupt()) {
		if (in_interrupt())
		mdelay(ms);
		} else {
		__set_current_state(TASK_INTERRUPTIBLE);
		schedule_timeout((ms * HZ + 999) / 1000);
		}
		else
		schedule_timeout_interruptible(msecs_to_jiffies(ms));
		}

		/* send a serial byte to the LCD panel. The caller is responsible for locking