Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 890fc711 authored by Hemant Gupta's avatar Hemant Gupta Committed by Gerrit - the friendly Code Review server
Browse files

HID: uhid: remove custom locking from uhid_hid_open/close 



Now that HID core enforces serialization of transport driver open/close
calls we can remove custom locking from uhid driver.

CRs-Fixed: 2218607
Change-Id: I87e2077a5357744d8aa88b9d9c8103ba6acbedca
Signed-off-by: default avatarHemant Gupta <hemantg@codeaurora.org>
parent 4cec0cd6

drivers/hid/uhid.c

+0 −4
Original line number Diff line number Diff line
@@ -144,13 +144,11 @@ static int uhid_hid_open(struct hid_device *hid) 
	struct uhid_device *uhid = hid->driver_data;

	int retval = 0;



	mutex_lock(&hid->ll_open_lock);

	if (!hid->ll_open_count++) {

		retval = uhid_queue_event(uhid, UHID_OPEN);

		if (retval)

			hid->ll_open_count--;

	}

	mutex_unlock(&hid->ll_open_lock);

	return retval;

}
@@ -158,10 +156,8 @@ static void uhid_hid_close(struct hid_device *hid) 
{

	struct uhid_device *uhid = hid->driver_data;



	mutex_lock(&hid->ll_open_lock);

	if (!--hid->ll_open_count)

		uhid_queue_event(uhid, UHID_CLOSE);

	mutex_unlock(&hid->ll_open_lock);

}



static int uhid_hid_parse(struct hid_device *hid)