Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 88f8b1bb authored by Gabriel Fernandez's avatar Gabriel Fernandez Committed by David S. Miller
Browse files

stmmac: Fix 'eth0: No PHY found' regression 



This patch manages the case when you have an Ethernet MAC with
a "fixed link", and not connected to a normal MDIO-managed PHY device.

The test of phy_bus_name was not helpful because it was never affected
and replaced by the mdio test node.

Signed-off-by: default avatarGabriel Fernandez <gabriel.fernandez@linaro.org>
Acked-by: default avatarGiuseppe Cavallaro <peppe.cavallaro@st.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ebc9780c

drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c

+1 −10
Original line number Diff line number Diff line
@@ -199,21 +199,12 @@ int stmmac_mdio_register(struct net_device *ndev) 
	struct stmmac_priv *priv = netdev_priv(ndev);

	struct stmmac_mdio_bus_data *mdio_bus_data = priv->plat->mdio_bus_data;

	int addr, found;

	struct device_node *mdio_node = NULL;

	struct device_node *child_node = NULL;

	struct device_node *mdio_node = priv->plat->mdio_node;



	if (!mdio_bus_data)

		return 0;



	if (IS_ENABLED(CONFIG_OF)) {

		for_each_child_of_node(priv->device->of_node, child_node) {

			if (of_device_is_compatible(child_node,

						    "snps,dwmac-mdio")) {

				mdio_node = child_node;

				break;

			}

		}



		if (mdio_node) {

			netdev_dbg(ndev, "FOUND MDIO subnode\n");

		} else {

drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c

+8 −1
Original line number Diff line number Diff line
@@ -110,6 +110,7 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac) 
	struct device_node *np = pdev->dev.of_node;

	struct plat_stmmacenet_data *plat;

	struct stmmac_dma_cfg *dma_cfg;

	struct device_node *child_node = NULL;



	plat = devm_kzalloc(&pdev->dev, sizeof(*plat), GFP_KERNEL);

	if (!plat)
@@ -140,13 +141,19 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac) 
		plat->phy_node = of_node_get(np);

	}



	for_each_child_of_node(np, child_node)

		if (of_device_is_compatible(child_node,	"snps,dwmac-mdio")) {

			plat->mdio_node = child_node;

			break;

		}



	/* "snps,phy-addr" is not a standard property. Mark it as deprecated

	 * and warn of its use. Remove this when phy node support is added.

	 */

	if (of_property_read_u32(np, "snps,phy-addr", &plat->phy_addr) == 0)

		dev_warn(&pdev->dev, "snps,phy-addr property is deprecated\n");



	if ((plat->phy_node && !of_phy_is_fixed_link(np)) || plat->phy_bus_name)

	if ((plat->phy_node && !of_phy_is_fixed_link(np)) || !plat->mdio_node)

		plat->mdio_bus_data = NULL;

	else

		plat->mdio_bus_data =

include/linux/stmmac.h

+1 −0
Original line number Diff line number Diff line
@@ -100,6 +100,7 @@ struct plat_stmmacenet_data { 
	int interface;

	struct stmmac_mdio_bus_data *mdio_bus_data;

	struct device_node *phy_node;

	struct device_node *mdio_node;

	struct stmmac_dma_cfg *dma_cfg;

	int clk_csr;

	int has_gmac;