Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 87e3c055 authored by Dan Carpenter's avatar Dan Carpenter Committed by Trond Myklebust
Browse files

SUNRPC: remove an unneeded NULL check in xprt_connect() 



We check "task->tk_rqstp" and then we dereference it without checking on
the next line.  The only caller is call_connect() and that has a check
which prevents it from calling xprt_connect() with a NULL.

                if (task->tk_status < 0)
                        return;

If "task->tk_rqstp" were NULL then "tk_status" would be -EAGAIN.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent b01dd1d8

net/sunrpc/xprt.c

+1 −3
Original line number Diff line number Diff line
@@ -715,9 +715,7 @@ void xprt_connect(struct rpc_task *task) 
	if (xprt_connected(xprt))

		xprt_release_write(xprt, task);

	else {

		if (task->tk_rqstp)

		task->tk_rqstp->rq_bytes_sent = 0;



		task->tk_timeout = task->tk_rqstp->rq_timeout;

		rpc_sleep_on(&xprt->pending, task, xprt_connect_status);