Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 86c7e683 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Vinod Koul
Browse files

dmaengine: ipu: remove bogus NO_IRQ reference 



A workaround for a warning introduced a use of the NO_IRQ
macro that should have been gone for a long time.

It is clear from the code that the value cannot actually
be used, but apparently there was a configuration at
some point that caused a warning, so instead of just
reverting that patch, this rearranges the code in a way that
the warning cannot reappear.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Fixes: 6ef41cf6 ("dmaengine :ipu: change ipu_irq_handler() to remove compile warning")
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent 524c6e04

drivers/dma/ipu/ipu_irq.c

+4 −5
Original line number Diff line number Diff line
@@ -286,22 +286,21 @@ static void ipu_irq_handler(struct irq_desc *desc) 
		raw_spin_unlock(&bank_lock);

		while ((line = ffs(status))) {

			struct ipu_irq_map *map;

			unsigned int irq = NO_IRQ;

			unsigned int irq;



			line--;

			status &= ~(1UL << line);



			raw_spin_lock(&bank_lock);

			map = src2map(32 * i + line);

			if (map)

				irq = map->irq;

			raw_spin_unlock(&bank_lock);



			if (!map) {

				raw_spin_unlock(&bank_lock);

				pr_err("IPU: Interrupt on unmapped source %u bank %d\n",

				       line, i);

				continue;

			}

			irq = map->irq;

			raw_spin_unlock(&bank_lock);

			generic_handle_irq(irq);

		}

	}