Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 85dc98d9 authored by Fubo Chen's avatar Fubo Chen Committed by James Bottomley
Browse files

[SCSI] target: fixed missing lock drop in error path 



The struct se_node_acl->device_list_lock needs to be released if either
sanity check for struct se_dev_entry->se_lun_acl or deve->se_lun fails.

Signed-off-by: default avatarFubo Chen <fubo.chen@gmail.com>
Signed-off-by: default avatarNicholas A. Bellinger <nab@linux-iscsi.org>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
parent 29fe609d

drivers/target/target_core_device.c

+2 −0
Original line number Diff line number Diff line
@@ -395,12 +395,14 @@ int core_update_device_list_for_node( 
				printk(KERN_ERR "struct se_dev_entry->se_lun_acl"

					" already set for demo mode -> explict"

					" LUN ACL transition\n");

				spin_unlock_irq(&nacl->device_list_lock);

				return -1;

			}

			if (deve->se_lun != lun) {

				printk(KERN_ERR "struct se_dev_entry->se_lun does"

					" match passed struct se_lun for demo mode"

					" -> explict LUN ACL transition\n");

				spin_unlock_irq(&nacl->device_list_lock);

				return -1;

			}

			deve->se_lun_acl = lun_acl;