Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 840a185d authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

aoe: remove dev_base_lock use from aoecmd_cfg_pkts() 



dev_base_lock is the legacy way to lock the device list, and is planned
to disappear. (writers hold RTNL, readers hold RCU lock)

Convert aoecmd_cfg_pkts() to RCU locking.

Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Cc: "Ed L. Cashin" <ecashin@coraid.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1d5439b9

drivers/block/aoe/aoecmd.c

+3 −3
Original line number Diff line number Diff line
@@ -297,8 +297,8 @@ aoecmd_cfg_pkts(ushort aoemajor, unsigned char aoeminor, struct sk_buff_head *qu 
	struct sk_buff *skb;

	struct net_device *ifp;



	read_lock(&dev_base_lock);

	for_each_netdev(&init_net, ifp) {

	rcu_read_lock();

	for_each_netdev_rcu(&init_net, ifp) {

		dev_hold(ifp);

		if (!is_aoe_netif(ifp))

			goto cont;
@@ -325,7 +325,7 @@ aoecmd_cfg_pkts(ushort aoemajor, unsigned char aoeminor, struct sk_buff_head *qu 
cont:

		dev_put(ifp);

	}

	read_unlock(&dev_base_lock);

	rcu_read_unlock();

}



static void