Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 83f26ad2 authored by David Henningsson's avatar David Henningsson Committed by Takashi Iwai
Browse files

ALSA: hda - fixup D3 pin and right channel mute on Haswell HDMI audio 

When graphics initializes the HDMI chip, sometimes this leads to
pins going into D3 and right channel being muted. If the audio driver
finishes initialization before the graphic driver does, this situation
becomes permanent.

This is a workaround that checks for this situation and corrects it on
playback prepare. It has been verified working on at least one machine.

BugLink: https://bugs.launchpad.net/bugs/1167270


Signed-off-by: default avatarDavid Henningsson <david.henningsson@canonical.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 5ead56f2

sound/pci/hda/patch_hdmi.c

+38 −0
Original line number Diff line number Diff line
@@ -1018,6 +1018,41 @@ static void hdmi_unsol_event(struct hda_codec *codec, unsigned int res) 
		hdmi_non_intrinsic_event(codec, res);

}



static void haswell_verify_pin_D0(struct hda_codec *codec, hda_nid_t nid)

{

	int pwr, lamp, ramp;



	pwr = snd_hda_codec_read(codec, nid, 0, AC_VERB_GET_POWER_STATE, 0);

	pwr = (pwr & AC_PWRST_ACTUAL) >> AC_PWRST_ACTUAL_SHIFT;

	if (pwr != AC_PWRST_D0) {

		snd_hda_codec_write(codec, nid, 0, AC_VERB_SET_POWER_STATE,

				    AC_PWRST_D0);

		msleep(40);

		pwr = snd_hda_codec_read(codec, nid, 0, AC_VERB_GET_POWER_STATE, 0);

		pwr = (pwr & AC_PWRST_ACTUAL) >> AC_PWRST_ACTUAL_SHIFT;

		snd_printd("Haswell HDMI audio: Power for pin 0x%x is now D%d\n", nid, pwr);

	}



	lamp = snd_hda_codec_read(codec, nid, 0,

				  AC_VERB_GET_AMP_GAIN_MUTE,

				  AC_AMP_GET_LEFT | AC_AMP_GET_OUTPUT);

	ramp = snd_hda_codec_read(codec, nid, 0,

				  AC_VERB_GET_AMP_GAIN_MUTE,

				  AC_AMP_GET_RIGHT | AC_AMP_GET_OUTPUT);

	if (lamp != ramp) {

		snd_hda_codec_write(codec, nid, 0, AC_VERB_SET_AMP_GAIN_MUTE,

				    AC_AMP_SET_RIGHT | AC_AMP_SET_OUTPUT | lamp);



		lamp = snd_hda_codec_read(codec, nid, 0,

				  AC_VERB_GET_AMP_GAIN_MUTE,

				  AC_AMP_GET_LEFT | AC_AMP_GET_OUTPUT);

		ramp = snd_hda_codec_read(codec, nid, 0,

				  AC_VERB_GET_AMP_GAIN_MUTE,

				  AC_AMP_GET_RIGHT | AC_AMP_GET_OUTPUT);

		snd_printd("Haswell HDMI audio: Mute after set on pin 0x%x: [0x%x 0x%x]\n", nid, lamp, ramp);

	}

}



/*

 * Callbacks

 */
@@ -1032,6 +1067,9 @@ static int hdmi_setup_stream(struct hda_codec *codec, hda_nid_t cvt_nid, 
	int pinctl;

	int new_pinctl = 0;



	if (codec->vendor_id == 0x80862807)

		haswell_verify_pin_D0(codec, pin_nid);



	if (snd_hda_query_pin_caps(codec, pin_nid) & AC_PINCAP_HBR) {

		pinctl = snd_hda_codec_read(codec, pin_nid, 0,

					    AC_VERB_GET_PIN_WIDGET_CONTROL, 0);