Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8221b3a8 authored by Jingoo Han's avatar Jingoo Han Committed by Greg Kroah-Hartman
Browse files

misc: ibmasm: remove unnecessary pci_set_drvdata() 



The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a840a72d

drivers/misc/ibmasm/module.c

+0 −2
Original line number Diff line number Diff line
@@ -153,7 +153,6 @@ static int ibmasm_init_one(struct pci_dev *pdev, const struct pci_device_id *id) 
error_heartbeat:

	ibmasm_event_buffer_exit(sp);

error_eventbuffer:

	pci_set_drvdata(pdev, NULL);

	kfree(sp);

error_kmalloc:

        pci_release_regions(pdev);
@@ -182,7 +181,6 @@ static void ibmasm_remove_one(struct pci_dev *pdev) 
	ibmasm_free_remote_input_dev(sp);

	iounmap(sp->base_address);

	ibmasm_event_buffer_exit(sp);

	pci_set_drvdata(pdev, NULL);

	kfree(sp);

	pci_release_regions(pdev);

	pci_disable_device(pdev);