Commit 81b50be0 authored Mar 15, 2013 by Ming Lei Committed by Greg Kroah-Hartman Mar 25, 2013

usbnet: qmi_wwan: comments on suspend failure



If suspend callback fails in system sleep context, usb core will
ignore the failure and let system sleep go ahead further, so
this patch comments on the case and requires that both
usbnet_suspend() and subdriver->suspend() MUST return 0 in
system sleep context.

Acked-by: David S. Miller <davem@davemloft.net>
Acked-by: Bjørn Mork <bjorn@mork.no>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9a44312a

drivers/net/usb/qmi_wwan.c

+5 −0

Original line number	Original line	Diff line number	Diff line
	@@ -271,6 +271,11 @@ static int qmi_wwan_suspend(struct usb_interface *intf, pm_message_t message)
	struct qmi_wwan_state info = (void )&dev->data;		struct qmi_wwan_state info = (void )&dev->data;
	int ret;		int ret;

			/*
			* Both usbnet_suspend() and subdriver->suspend() MUST return 0
			* in system sleep context, otherwise, the resume callback has
			* to recover device from previous suspend failure.
			*/
	ret = usbnet_suspend(intf, message);		ret = usbnet_suspend(intf, message);
	if (ret < 0)		if (ret < 0)
	goto err;		goto err;