Commit 811ad4b3 authored Jul 03, 2018 by Heiner Kallweit Committed by Greg Kroah-Hartman Jul 25, 2018

net: phy: fix flag masking in __set_phy_supported



[ Upstream commit df8ed346d4a806a6eef2db5924285e839604b3f9 ]

Currently also the pause flags are removed from phydev->supported because
they're not included in PHY_DEFAULT_FEATURES. I don't think this is
intended, especially when considering that this function can be called
via phy_set_max_speed() anywhere in a driver. Change the masking to mask
out only the values we're going to change. In addition remove the
misleading comment, job of this small function is just to adjust the
supported and advertised speeds.

Fixes: f3a6bd39 ("phylib: Add phy_set_max_speed helper")
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 78382d78

drivers/net/phy/phy_device.c

+2 −5

Original line number	Diff line number	Diff line
		@@ -1686,11 +1686,8 @@ EXPORT_SYMBOL(genphy_loopback);

		static int __set_phy_supported(struct phy_device *phydev, u32 max_speed)
		{
		/* The default values for phydev->supported are provided by the PHY
		* driver "features" member, we want to reset to sane defaults first
		* before supporting higher speeds.
		*/
		phydev->supported &= PHY_DEFAULT_FEATURES;
		phydev->supported &= ~(PHY_1000BT_FEATURES \| PHY_100BT_FEATURES \|
		PHY_10BT_FEATURES);

		switch (max_speed) {
		default: