Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 810e006a authored by Colin Ian King's avatar Colin Ian King Committed by Sebastian Reichel
Browse files

power: supply: lp8788: Make several arrays static const * const 



Don't populate various read only arrays on the stack but make them
static const, making the object code smaller and saves 148 bytes
overall:

Before:
   text    data     bss     dec     hex filename
  11940    4496      64   16500    4074 lp8788-charger.o

After:
   text    data     bss     dec     hex filename
  11472    4816      64   16352    3fe0 lp8788-charger.o

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.co.uk>
parent 18a89d5c

drivers/power/supply/lp8788-charger.c

+12 −6
Original line number Diff line number Diff line
@@ -626,7 +626,7 @@ static ssize_t lp8788_show_charger_status(struct device *dev, 
{

	struct lp8788_charger *pchg = dev_get_drvdata(dev);

	enum lp8788_charging_state state;

	char *desc[LP8788_MAX_CHG_STATE] = {

	static const char * const desc[LP8788_MAX_CHG_STATE] = {

		[LP8788_OFF] = "CHARGER OFF",

		[LP8788_WARM_UP] = "WARM UP",

		[LP8788_LOW_INPUT] = "LOW INPUT STATE",
@@ -650,8 +650,10 @@ static ssize_t lp8788_show_eoc_time(struct device *dev, 
				struct device_attribute *attr, char *buf)

{

	struct lp8788_charger *pchg = dev_get_drvdata(dev);

	char *stime[] = { "400ms", "5min", "10min", "15min",

			"20min", "25min", "30min", "No timeout" };

	static const char * const stime[] = {

		"400ms", "5min", "10min", "15min",

		"20min", "25min", "30min", "No timeout"

	};

	u8 val;



	lp8788_read_byte(pchg->lp, LP8788_CHG_EOC, &val);
@@ -665,9 +667,13 @@ static ssize_t lp8788_show_eoc_level(struct device *dev, 
				struct device_attribute *attr, char *buf)

{

	struct lp8788_charger *pchg = dev_get_drvdata(dev);

	char *abs_level[] = { "25mA", "49mA", "75mA", "98mA" };

	char *relative_level[] = { "5%", "10%", "15%", "20%" };

	char *level;

	static const char * const abs_level[] = {

			"25mA", "49mA", "75mA", "98mA"

	};

	static const char * const relative_level[] = {

			"5%", "10%", "15%", "20%"

	};

	const char *level;

	u8 val;

	u8 mode;