Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 80b054ba authored by Sebastian Ott's avatar Sebastian Ott Committed by Martin Schwidefsky
Browse files

s390/pci: sysfs remove strlen 



Get rid of the strlen calls, use the return value of sprintf instead.

Reviewed-by: default avatarGerald Schaefer <gerald.schaefer@de.ibm.com>
Signed-off-by: default avatarSebastian Ott <sebott@linux.vnet.ibm.com>
Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
parent 8b2a7e60

arch/s390/pci/pci_sysfs.c

+4 −8
Original line number Diff line number Diff line
@@ -17,8 +17,7 @@ static ssize_t show_fid(struct device *dev, struct device_attribute *attr, 
{

	struct zpci_dev *zdev = get_zdev(to_pci_dev(dev));



	sprintf(buf, "0x%08x\n", zdev->fid);

	return strlen(buf);

	return sprintf(buf, "0x%08x\n", zdev->fid);

}

static DEVICE_ATTR(function_id, S_IRUGO, show_fid, NULL);
@@ -27,8 +26,7 @@ static ssize_t show_fh(struct device *dev, struct device_attribute *attr, 
{

	struct zpci_dev *zdev = get_zdev(to_pci_dev(dev));



	sprintf(buf, "0x%08x\n", zdev->fh);

	return strlen(buf);

	return sprintf(buf, "0x%08x\n", zdev->fh);

}

static DEVICE_ATTR(function_handle, S_IRUGO, show_fh, NULL);
@@ -37,8 +35,7 @@ static ssize_t show_pchid(struct device *dev, struct device_attribute *attr, 
{

	struct zpci_dev *zdev = get_zdev(to_pci_dev(dev));



	sprintf(buf, "0x%04x\n", zdev->pchid);

	return strlen(buf);

	return sprintf(buf, "0x%04x\n", zdev->pchid);

}

static DEVICE_ATTR(pchid, S_IRUGO, show_pchid, NULL);
@@ -47,8 +44,7 @@ static ssize_t show_pfgid(struct device *dev, struct device_attribute *attr, 
{

	struct zpci_dev *zdev = get_zdev(to_pci_dev(dev));



	sprintf(buf, "0x%02x\n", zdev->pfgid);

	return strlen(buf);

	return sprintf(buf, "0x%02x\n", zdev->pfgid);

}

static DEVICE_ATTR(pfgid, S_IRUGO, show_pfgid, NULL);