Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 80408357 authored by Vasiliy Kulikov's avatar Vasiliy Kulikov Committed by Matthew Garrett
Browse files

platform: x86: asus_acpi: world-writable procfs files 



Don't allow everybody to change ACPI settings.  The comment says that it
is done deliberatelly, however, the comment before disp_proc_write()
says that at least one of these setting is experimental.

Signed-off-by: default avatarVasiliy Kulikov <segoon@openwall.com>
Signed-off-by: default avatarMatthew Garrett <mjg@redhat.com>
parent 8a6a142c

drivers/platform/x86/asus_acpi.c

+1 −7
Original line number Diff line number Diff line
@@ -1081,14 +1081,8 @@ static int asus_hotk_add_fs(struct acpi_device *device) 
	struct proc_dir_entry *proc;

	mode_t mode;



	/*

	 * If parameter uid or gid is not changed, keep the default setting for

	 * our proc entries (-rw-rw-rw-) else, it means we care about security,

	 * and then set to -rw-rw----

	 */



	if ((asus_uid == 0) && (asus_gid == 0)) {

		mode = S_IFREG | S_IRUGO | S_IWUGO;

		mode = S_IFREG | S_IRUGO | S_IWUSR | S_IWGRP;

	} else {

		mode = S_IFREG | S_IRUSR | S_IRGRP | S_IWUSR | S_IWGRP;

		printk(KERN_WARNING "  asus_uid and asus_gid parameters are "