Commit 7f304b9e authored Jun 29, 2017 by Xin Long Committed by David S. Miller Jul 01, 2017

sctp: remove an unnecessary check from sctp_endpoint_destroy



ep->base.sk gets it's value since sctp_endpoint_new, nowhere
will change it. So there's no need to check if it's null, as
it can never be null.

Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 0b58e6db

net/sctp/endpointola.c

+6 −8

Original line number	Diff line number	Diff line
		@@ -268,16 +268,14 @@ static void sctp_endpoint_destroy(struct sctp_endpoint *ep)

		memset(ep->secret_key, 0, sizeof(ep->secret_key));

		/* Give up our hold on the sock. */
		sk = ep->base.sk;
		if (sk != NULL) {
		/* Remove and free the port */
		if (sctp_sk(sk)->bind_hash)
		sctp_put_port(sk);

		sctp_sk(sk)->ep = NULL;
		/* Give up our hold on the sock */
		sock_put(sk);
		}

		kfree(ep);
		SCTP_DBG_OBJCNT_DEC(ep);