Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7f2a7ce1 authored by Brian Norris's avatar Brian Norris
Browse files

mtd: onenand: drop dead code 



'ret' is always zero, so this is all dead code.

This should quiet Coverity CID #1226739.

Signed-off-by: default avatarBrian Norris <computersforpeace@gmail.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
parent dc52499e

drivers/mtd/onenand/onenand_base.c

+3 −9
Original line number Original line Diff line number Diff line
@@ -1743,7 +1743,6 @@ static int onenand_panic_write(struct mtd_info *mtd, loff_t to, size_t len, 
	struct onenand_chip *this = mtd->priv;

	struct onenand_chip *this = mtd->priv;

	int column, subpage;

	int column, subpage;

	int written = 0;

	int written = 0;

	int ret = 0;





	if (this->state == FL_PM_SUSPENDED)

	if (this->state == FL_PM_SUSPENDED)

		return -EBUSY;

		return -EBUSY;
@@ -1786,15 +1785,10 @@ static int onenand_panic_write(struct mtd_info *mtd, loff_t to, size_t len, 
		onenand_panic_wait(mtd);

		onenand_panic_wait(mtd);





		/* In partial page write we don't update bufferram */

		/* In partial page write we don't update bufferram */

		onenand_update_bufferram(mtd, to, !ret && !subpage);

		onenand_update_bufferram(mtd, to, !subpage);

		if (ONENAND_IS_2PLANE(this)) {

		if (ONENAND_IS_2PLANE(this)) {

			ONENAND_SET_BUFFERRAM1(this);

			ONENAND_SET_BUFFERRAM1(this);

			onenand_update_bufferram(mtd, to + this->writesize, !ret && !subpage);

			onenand_update_bufferram(mtd, to + this->writesize, !subpage);

		}



		if (ret) {

			printk(KERN_ERR "%s: write failed %d\n", __func__, ret);

			break;

		}

		}





		written += thislen;

		written += thislen;
@@ -1808,7 +1802,7 @@ static int onenand_panic_write(struct mtd_info *mtd, loff_t to, size_t len, 
	}

	}





	*retlen = written;

	*retlen = written;

	return ret;

	return 0;

}

}





/**

/**