Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7f049f2f authored by Steve Wise's avatar Steve Wise Committed by Roland Dreier
Browse files

RDMA/cxgb3: Hold rtnl_lock() around ethtool get_drvinfo call 



Currently the call into cxgb3 to get the driver info is not serialized.
The iw_cxgb3 module needs to hold the rtnl_lock around the ethtool ops
call like dev_ioctl() does.

Signed-off-by: default avatarSteve Wise <swise@opengridcomputing.com>
Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
parent 908cf9a5

drivers/infiniband/hw/cxgb3/iwch_provider.c

+5 −0
Original line number Diff line number Diff line
@@ -39,6 +39,7 @@ 
#include <linux/list.h>

#include <linux/spinlock.h>

#include <linux/ethtool.h>

#include <linux/rtnetlink.h>



#include <asm/io.h>

#include <asm/irq.h>
@@ -1053,7 +1054,9 @@ static ssize_t show_fw_ver(struct class_device *cdev, char *buf) 
	struct net_device *lldev = dev->rdev.t3cdev_p->lldev;



	PDBG("%s class dev 0x%p\n", __FUNCTION__, cdev);

	rtnl_lock();

	lldev->ethtool_ops->get_drvinfo(lldev, &info);

	rtnl_unlock();

	return sprintf(buf, "%s\n", info.fw_version);

}
@@ -1065,7 +1068,9 @@ static ssize_t show_hca(struct class_device *cdev, char *buf) 
	struct net_device *lldev = dev->rdev.t3cdev_p->lldev;



	PDBG("%s class dev 0x%p\n", __FUNCTION__, cdev);

	rtnl_lock();

	lldev->ethtool_ops->get_drvinfo(lldev, &info);

	rtnl_unlock();

	return sprintf(buf, "%s\n", info.driver);

}