Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7cc9eb6e authored by Jesper Dangaard Brouer's avatar Jesper Dangaard Brouer Committed by Pablo Neira Ayuso
Browse files

netfilter: SYNPROXY: let unrelated packets continue 



Packets reaching SYNPROXY were default dropped, as they were most
likely invalid (given the recommended state matching).  This
patch, changes SYNPROXY target to let packets, not consumed,
continue being processed by the stack.

This will be more in line other target modules. As it will allow
more flexible configurations of handling, logging or matching on
packets in INVALID states.

Signed-off-by: default avatarJesper Dangaard Brouer <brouer@redhat.com>
Acked-by: default avatarPatrick McHardy <kaber@trash.net>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent f4de4c89

net/ipv4/netfilter/ipt_SYNPROXY.c

+6 −2
Original line number Diff line number Diff line
@@ -285,13 +285,17 @@ synproxy_tg4(struct sk_buff *skb, const struct xt_action_param *par) 
					  XT_SYNPROXY_OPT_ECN);



		synproxy_send_client_synack(skb, th, &opts);

	} else if (th->ack && !(th->fin || th->rst || th->syn))

		return NF_DROP;



	} else if (th->ack && !(th->fin || th->rst || th->syn)) {

		/* ACK from client */

		synproxy_recv_client_ack(snet, skb, th, &opts, ntohl(th->seq));



		return NF_DROP;

	}



	return XT_CONTINUE;

}



static unsigned int ipv4_synproxy_hook(unsigned int hooknum,

				       struct sk_buff *skb,

				       const struct net_device *in,

net/ipv6/netfilter/ip6t_SYNPROXY.c

+6 −2
Original line number Diff line number Diff line
@@ -300,13 +300,17 @@ synproxy_tg6(struct sk_buff *skb, const struct xt_action_param *par) 
					  XT_SYNPROXY_OPT_ECN);



		synproxy_send_client_synack(skb, th, &opts);

	} else if (th->ack && !(th->fin || th->rst || th->syn))

		return NF_DROP;



	} else if (th->ack && !(th->fin || th->rst || th->syn)) {

		/* ACK from client */

		synproxy_recv_client_ack(snet, skb, th, &opts, ntohl(th->seq));



		return NF_DROP;

	}



	return XT_CONTINUE;

}



static unsigned int ipv6_synproxy_hook(unsigned int hooknum,

				       struct sk_buff *skb,

				       const struct net_device *in,