Commit 7c84e5e9 authored Mar 06, 2018 by Arvind Yadav Committed by Greg Kroah-Hartman May 30, 2018

workqueue: use put_device() instead of kfree()



[ Upstream commit 537f4146c53c95aac977852b371bafb9c6755ee1 ]

Never directly free @dev after calling device_register(), even
if it returned an error! Always use put_device() to give up the
reference initialized in this function instead.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 845c2de9

kernel/workqueue.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -5350,7 +5350,7 @@ int workqueue_sysfs_register(struct workqueue_struct *wq)

		ret = device_register(&wq_dev->dev);
		if (ret) {
		kfree(wq_dev);
		put_device(&wq_dev->dev);
		wq->wq_dev = NULL;
		return ret;
		}