Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7b18389d authored by Igor Grinberg's avatar Igor Grinberg Committed by Greg Kroah-Hartman
Browse files

ARM: OMAP: USB: fix warning on EHCI PHY reset path 



When PHY reset pin is connected to a GPIO on external GPIO chip
(e.g. I2C), we should not call the gpio_set_value() function, but
gpio_set_value_cansleep().

Signed-off-by: default avatarIgor Grinberg <grinberg@compulab.co.il>
Acked-by: default avatarFelipe Balbi <balbi@ti.com>
Tested-by: default avatarGovindraj.R <govindraj.raja@ti.com>
Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1f339d84

drivers/usb/host/ehci-omap.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -249,10 +249,10 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev) 
		udelay(10);

		udelay(10);





		if (gpio_is_valid(pdata->reset_gpio_port[0]))

		if (gpio_is_valid(pdata->reset_gpio_port[0]))

			gpio_set_value(pdata->reset_gpio_port[0], 1);

			gpio_set_value_cansleep(pdata->reset_gpio_port[0], 1);





		if (gpio_is_valid(pdata->reset_gpio_port[1]))

		if (gpio_is_valid(pdata->reset_gpio_port[1]))

			gpio_set_value(pdata->reset_gpio_port[1], 1);

			gpio_set_value_cansleep(pdata->reset_gpio_port[1], 1);

	}

	}





	ret = usb_add_hcd(hcd, irq, IRQF_SHARED);

	ret = usb_add_hcd(hcd, irq, IRQF_SHARED);