Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7a3f0984 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

tty: rocket: fix invalid user-pointer checks 



Drop invalid user-pointer checks from custom ioctl handlers.

A NULL-pointer can be valid in user space and copy_to_user() takes care
of sanity checking.

Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6f8ada12

drivers/tty/rocket.c

+0 −4
Original line number Diff line number Diff line
@@ -1189,8 +1189,6 @@ static int get_config(struct r_port *info, struct rocket_config __user *retinfo) 
{

	struct rocket_config tmp;



	if (!retinfo)

		return -EFAULT;

	memset(&tmp, 0, sizeof (tmp));

	mutex_lock(&info->port.mutex);

	tmp.line = info->line;
@@ -1255,8 +1253,6 @@ static int get_ports(struct r_port *info, struct rocket_ports __user *retports) 
	struct rocket_ports tmp;

	int board;



	if (!retports)

		return -EFAULT;

	memset(&tmp, 0, sizeof (tmp));

	tmp.tty_major = rocket_driver->major;