Commit 79e0348c authored May 25, 2017 by Masahiro Yamada Committed by Boris Brezillon Jun 01, 2017

mtd: nand: check ecc->total sanity in nand_scan_tail



Drivers are supposed to set correct ecc->{size,strength,bytes} before
calling nand_scan_tail(), but it does not complain about ecc->total
bigger than oobsize.

In this case, chip->scan_bbt() crashes due to memory corruption, but
it is hard to debug.  It would be kind to fail it earlier with a clear
message.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>

parent 2165c4a1

drivers/mtd/nand/nand_base.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -4789,6 +4789,11 @@ int nand_scan_tail(struct mtd_info *mtd)
		goto err_free;
		}
		ecc->total = ecc->steps * ecc->bytes;
		if (ecc->total > mtd->oobsize) {
		WARN(1, "Total number of ECC bytes exceeded oobsize\n");
		ret = -EINVAL;
		goto err_free;
		}

		/*
		* The number of bytes available for a client to place data into