Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 795ef788 authored by Colin Ian King's avatar Colin Ian King Committed by Tejun Heo
Browse files

libata: zpodd: make arrays cdb static, reduces object code size 



Don't populate the arrays cdb on the stack, instead make them static.
Makes the object code smaller by 230 bytes:

Before:
   text	   data	    bss	    dec	    hex	filename
   3797	    240	      0	   4037	    fc5	drivers/ata/libata-zpodd.o

After:
   text	   data	    bss	    dec	    hex	filename
   3407	    400	      0	   3807	    edf	drivers/ata/libata-zpodd.o

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent f723fa4e

drivers/ata/libata-zpodd.c

+2 −2
Original line number Diff line number Diff line
@@ -34,7 +34,7 @@ struct zpodd { 
static int eject_tray(struct ata_device *dev)

{

	struct ata_taskfile tf;

	const char cdb[] = {  GPCMD_START_STOP_UNIT,

	static const char cdb[] = {  GPCMD_START_STOP_UNIT,

		0, 0, 0,

		0x02,     /* LoEj */

		0, 0, 0, 0, 0, 0, 0,
@@ -55,7 +55,7 @@ static enum odd_mech_type zpodd_get_mech_type(struct ata_device *dev) 
	unsigned int ret;

	struct rm_feature_desc *desc = (void *)(buf + 8);

	struct ata_taskfile tf;

	char cdb[] = {  GPCMD_GET_CONFIGURATION,

	static const char cdb[] = {  GPCMD_GET_CONFIGURATION,

			2,      /* only 1 feature descriptor requested */

			0, 3,   /* 3, removable medium feature */

			0, 0, 0,/* reserved */