Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 78d81d15 authored by Flavio Leitner's avatar Flavio Leitner Committed by David S. Miller
Browse files

TCP: remove TCP_DEBUG 



It was enabled by default and the messages guarded
by the define are useful.

Signed-off-by: default avatarFlavio Leitner <fbl@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8b185735

include/net/tcp.h

+0 −1
Original line number Diff line number Diff line
@@ -18,7 +18,6 @@ 
#ifndef _TCP_H

#define _TCP_H



#define TCP_DEBUG 1

#define FASTRETRANS_DEBUG 1



#include <linux/list.h>

net/ipv4/tcp.c

+0 −2
Original line number Diff line number Diff line
@@ -1193,13 +1193,11 @@ void tcp_cleanup_rbuf(struct sock *sk, int copied) 
	struct tcp_sock *tp = tcp_sk(sk);

	int time_to_ack = 0;



#if TCP_DEBUG

	struct sk_buff *skb = skb_peek(&sk->sk_receive_queue);



	WARN(skb && !before(tp->copied_seq, TCP_SKB_CB(skb)->end_seq),

	     "cleanup rbuf bug: copied %X seq %X rcvnxt %X\n",

	     tp->copied_seq, TCP_SKB_CB(skb)->end_seq, tp->rcv_nxt);

#endif



	if (inet_csk_ack_scheduled(sk)) {

		const struct inet_connection_sock *icsk = inet_csk(sk);

net/ipv4/tcp_timer.c

+0 −2
Original line number Diff line number Diff line
@@ -334,7 +334,6 @@ void tcp_retransmit_timer(struct sock *sk) 
		 * connection. If the socket is an orphan, time it out,

		 * we cannot allow such beasts to hang infinitely.

		 */

#ifdef TCP_DEBUG

		struct inet_sock *inet = inet_sk(sk);

		if (sk->sk_family == AF_INET) {

			LIMIT_NETDEBUG(KERN_DEBUG "TCP: Peer %pI4:%u/%u unexpectedly shrunk window %u:%u (repaired)\n",
@@ -348,7 +347,6 @@ void tcp_retransmit_timer(struct sock *sk) 
			       &np->daddr, ntohs(inet->inet_dport),

			       inet->inet_num, tp->snd_una, tp->snd_nxt);

		}

#endif

#endif

		if (tcp_time_stamp - tp->rcv_tstamp > TCP_RTO_MAX) {

			tcp_write_err(sk);