Commit 78981a7c authored Jan 30, 2007 by Robert Hancock Committed by Jeff Garzik Jan 30, 2007

libata: fix translation for START STOP UNIT



libata's SCSI translation for the SCSI START STOP UNIT command with the
START bit clear (i.e.  stopping the drive) appears to be incorrect.  It
sends an ATA STANDBY command with the time period set to 0, which the code
comment says means "now", but the ATA standard says this means disable the
standby timer, which effectively does nothing.  Change this to issue a
STANDBY IMMEDIATE command which will actually spin the drive down.  The SAT
(SCSI/ATA Translation) standard revision 9 concurs with this choice.

Signed-off-by: Robert Hancock <hancockr@shaw.ca>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

parent af068bd1

drivers/ata/libata-scsi.c

+4 −5

Original line number	Diff line number	Diff line
		@@ -1022,11 +1022,10 @@ static unsigned int ata_scsi_start_stop_xlat(struct ata_queued_cmd *qc)
		}

		tf->command = ATA_CMD_VERIFY; /* READ VERIFY */
		} else {
		tf->nsect = 0; /* time period value (0 implies now) */
		tf->command = ATA_CMD_STANDBY;
		/* Consider: ATA STANDBY IMMEDIATE command */
		}
		} else
		/* Issue ATA STANDBY IMMEDIATE command */
		tf->command = ATA_CMD_STANDBYNOW1;

		/*
		* Standby and Idle condition timers could be implemented but that
		* would require libata to implement the Power condition mode page