Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 772a7b7a authored by Archit Taneja's avatar Archit Taneja Committed by Mauro Carvalho Chehab
Browse files

[media] v4l: ti-vpe: Use video_device_release_empty 



The video_device struct is currently embedded in the driver data struct vpe_dev.
A vpe_dev instance is allocated by the driver, and the memory for the vfd is a
part of this struct.

The v4l2 core, however, manages the removal of the vfd region, through the
video_device's .release() op, which currently is the helper
video_device_release. This causes memory corruption, and leads to issues when
we try to re-insert the vpe module.

Use the video_device_release_empty helper function instead.

Reviewed-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarArchit Taneja <archit@ti.com>
Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
parent db476163

drivers/media/platform/ti-vpe/vpe.c

+1 −1
Original line number Diff line number Diff line
@@ -2005,7 +2005,7 @@ static struct video_device vpe_videodev = { 
	.fops		= &vpe_fops,

	.ioctl_ops	= &vpe_ioctl_ops,

	.minor		= -1,

	.release	= video_device_release,

	.release	= video_device_release_empty,

	.vfl_dir	= VFL_DIR_M2M,

};